netdev - Re: [PATCH net] net: netsec: Fix signedness bug in netsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Sep 2019 10:04:05 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     jaswinder.singh@...aro.org, ilias.apalodimas@...aro.org,
        ast@...nel.org, daniel@...earbox.net, jakub.kicinski@...ronome.com,
        hawk@...nel.org, john.fastabend@...il.com, kafai@...com,
        songliubraving@...com, yhs@...com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: netsec: Fix signedness bug in netsec_probe()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 13:56:38 +0300

> The "priv->phy_interface" variable is an enum and in this context GCC
> will treat it as an unsigned int so the error handling is never
> triggered.
> 
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.