netdev - Re: [PATCH net] enetc: Fix a signedness bug in enetc_of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.100412.283048791655860337.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:04:12 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     claudiu.manoil@....com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] enetc: Fix a signedness bug in enetc_of_get_phy()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 13:57:14 +0300

> The "priv->if_mode" is type phy_interface_t which is an enum.  In this
> context GCC will treat the enum as an unsigned int so this error
> handling is never triggered.
> 
> Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.