netdev - Re: [PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d256f178-ec5a-abaa-1528-0690d059b243@gmail.com>
Date:   Mon, 30 Sep 2019 10:42:35 -0600
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
        stephen@...workplumber.org
Subject: Re: [PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

On 9/28/19 2:22 PM, Roopa Prabhu wrote:
> +
> +	req.ndm.ndm_family = dst.family;
> +	if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) < 0)
> +		return -1;
> +
> +	if (d) {
> +		ll_init_map(&rth);

ll_init_map is not needed and really not something you want to do (it
does a full link dump)