netdev - Re: [PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUgziCGhqe8-tXh1hkD_fzjXVS4HfsedT20tDwrXMm3SRA@mail.gmail.com>
Date:   Mon, 30 Sep 2019 21:44:32 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 net-next v2 2/2] ipneigh: neigh get support

On Mon, Sep 30, 2019 at 9:42 AM David Ahern <dsahern@...il.com> wrote:
>
> On 9/28/19 2:22 PM, Roopa Prabhu wrote:
> > +
> > +     req.ndm.ndm_family = dst.family;
> > +     if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) < 0)
> > +             return -1;
> > +
> > +     if (d) {
> > +             ll_init_map(&rth);
>
> ll_init_map is not needed and really not something you want to do (it
> does a full link dump)
>

ok got it, the get index macro does a getlink if map is not initialized.
(there are still many calls to init_map... possibly for cases that
require querying of multiple links)