lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Sep 2019 07:53:10 +0200 From: Sean Nyekjaer <sean@...nix.com> To: Joakim Zhang <qiangqing.zhang@....com>, "mkl@...gutronix.de" <mkl@...gutronix.de>, "linux-can@...r.kernel.org" <linux-can@...r.kernel.org> Cc: "wg@...ndegger.com" <wg@...ndegger.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, dl-linux-imx <linux-imx@....com> Subject: Re: [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code On 29/09/2019 10.32, Joakim Zhang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together to simplify > the code. > > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com> Reviewed-by: Sean Nyekjaer <sean@...nix.com> > --- > drivers/net/can/flexcan.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > index b3edaf6a5a61..3cfa6037f03c 100644 > --- a/drivers/net/can/flexcan.c > +++ b/drivers/net/can/flexcan.c > @@ -1507,7 +1507,6 @@ static int flexcan_probe(struct platform_device *pdev) > struct net_device *dev; > struct flexcan_priv *priv; > struct regulator *reg_xceiver; > - struct resource *mem; > struct clk *clk_ipg = NULL, *clk_per = NULL; > struct flexcan_regs __iomem *regs; > int err, irq; > @@ -1538,12 +1537,11 @@ static int flexcan_probe(struct platform_device *pdev) > clock_freq = clk_get_rate(clk_per); > } > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > irq = platform_get_irq(pdev, 0); > if (irq <= 0) > return -ENODEV; > > - regs = devm_ioremap_resource(&pdev->dev, mem); > + regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(regs)) > return PTR_ERR(regs); > >
Powered by blists - more mailing lists