netdev - Re: DSA driver kernel extension for dsa mv88e6190 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Sep 2019 07:51:25 +0200
From:   Zoran Stojsavljevic <zoran.stojsavljevic@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: DSA driver kernel extension for dsa mv88e6190 switch

> The very last line is wrong.
> ifconfig eth0 192.168.1.4 up

Typo. It was fixed after few hours I created the gist.

> You should put the IP address on the bridge, not the master
> device eth0.
> ip addr add 192.168.1.4/24 dev br0

Noted. Thank you.

> FYI: ifconfig has been deprecated for maybe a decade?

I am an old dog, and old dogs could not be tough to new tricks. ;-)

This is why I always install on Debian additional net-tools package.

I guess, time to move to modern ip command.
_______

Please, please, keep me in the loop about DSA patches.

Many many thanks for advises/emails,
Zoran
_______


On Mon, Sep 30, 2019 at 3:44 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > I wrote my (very first) public GIST about that. Please, could you
> > review it, and point to the any logical bugs in there?
> > https://gist.github.com/ZoranStojsavljevic/423b96e2ca3bd581f7ce417cb410c465
>
> The very last line is wrong.
>
> ifconfig eth0 192.168.1.4 up
>
> You should put the IP address on the bridge, not the master device
> eth0.
>
> ip addr add 192.168.1.4/24 dev br0
>
> FYI: ifconfig has been deprecated for maybe a decade?
>
>    Andrew