netdev - Re: DSA driver kernel extension for dsa mv88e6190 switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190930014440.GC6032@lunn.ch>
Date:   Mon, 30 Sep 2019 03:44:40 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Zoran Stojsavljevic <zoran.stojsavljevic@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: DSA driver kernel extension for dsa mv88e6190 switch

> I wrote my (very first) public GIST about that. Please, could you
> review it, and point to the any logical bugs in there?
> https://gist.github.com/ZoranStojsavljevic/423b96e2ca3bd581f7ce417cb410c465

The very last line is wrong.

ifconfig eth0 192.168.1.4 up

You should put the IP address on the bridge, not the master device
eth0.

ip addr add 192.168.1.4/24 dev br0

FYI: ifconfig has been deprecated for maybe a decade?

   Andrew