netdev - Re: [PATCH net] net/rds: Fix error handling in rds_ib_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Oct 2019 10:47:55 -0700
From:   santosh.shilimkar@...cle.com
To:     Sudhakar Dindukurti <sudhakar.dindukurti@...cle.com>,
        netdev@...r.kernel.org, davem@...emloft.net,
        rds-devel@....oracle.com
Cc:     Dotan Barak <dotanb@....mellanox.co.il>
Subject: Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()

On 10/1/19 10:21 AM, Sudhakar Dindukurti wrote:
> From: Dotan Barak <dotanb@....mellanox.co.il>
> 
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
> 
> Signed-off-by: Dotan Barak <dotanb@....mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@...cle.com>
> ---
Thanks Sudhakar !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>