netdev - Re: [PATCH net] net/rds: Fix error handling in rds_ib_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191002.121809.873130939496092066.davem@davemloft.net>
Date:   Wed, 02 Oct 2019 12:18:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sudhakar.dindukurti@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com,
        rds-devel@....oracle.com, dotanb@....mellanox.co.il
Subject: Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()

From: Sudhakar Dindukurti <sudhakar.dindukurti@...cle.com>
Date: Tue,  1 Oct 2019 10:21:02 -0700

> From: Dotan Barak <dotanb@....mellanox.co.il>
> 
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
> 
> Signed-off-by: Dotan Barak <dotanb@....mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@...cle.com>

Applied.