netdev - RE: [PATCH bpf-next 1/6] selftests/bpf: undo GCC-specific bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d93a49c2b41f_85b2b0fc76de5b468@john-XPS-13-9370.notmuch>
Date:   Tue, 01 Oct 2019 12:10:20 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: RE: [PATCH bpf-next 1/6] selftests/bpf: undo GCC-specific
 bpf_helpers.h changes

Andrii Nakryiko wrote:
> Having GCC provide its own bpf-helper.h is not the right approach and is
> going to be changed. Undo bpf_helpers.h change before moving
> bpf_helpers.h into libbpf.
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  tools/testing/selftests/bpf/bpf_helpers.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h
> index 54a50699bbfd..a1d9b97b8e15 100644
> --- a/tools/testing/selftests/bpf/bpf_helpers.h
> +++ b/tools/testing/selftests/bpf/bpf_helpers.h
> @@ -13,8 +13,6 @@
>  			 ##__VA_ARGS__);		\
>  })
>  
> -#ifdef __clang__
> -
>  /* helper macro to place programs, maps, license in
>   * different sections in elf_bpf file. Section names
>   * are interpreted by elf_bpf loader
> @@ -258,12 +256,6 @@ struct bpf_map_def {
>  	unsigned int numa_node;
>  };
>  
> -#else
> -
> -#include <bpf-helpers.h>
> -
> -#endif
> -
>  #define BPF_ANNOTATE_KV_PAIR(name, type_key, type_val)		\
>  	struct ____btf_map_##name {				\
>  		type_key key;					\
> -- 
> 2.17.1
> 

Acked-by: John Fastabend <john.fastabend@...il.com>