netdev - RE: [PATCH bpf-next 5/6] selftests/bpf: adjust CO-RE reloc tests for new BPF_CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d93a58be3b5f_85b2b0fc76de5b4e@john-XPS-13-9370.notmuch>
Date:   Tue, 01 Oct 2019 12:14:19 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: RE: [PATCH bpf-next 5/6] selftests/bpf: adjust CO-RE reloc tests for
 new BPF_CORE_READ macro

Andrii Nakryiko wrote:
> Given introduction of variadic BPF_CORE_READ with slightly different
> syntax and semantics, define CORE_READ, which is a thin wrapper around
> low-level bpf_core_read() macro, which in turn is just a wrapper around
> bpf_probe_read(). BPF_CORE_READ is higher-level variadic macro
> supporting multi-pointer reads and are tested separately.
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  .../bpf/progs/test_core_reloc_arrays.c         | 10 ++++++----
>  .../bpf/progs/test_core_reloc_flavors.c        |  8 +++++---
>  .../selftests/bpf/progs/test_core_reloc_ints.c | 18 ++++++++++--------
>  .../bpf/progs/test_core_reloc_kernel.c         |  6 ++++--
>  .../selftests/bpf/progs/test_core_reloc_misc.c |  8 +++++---
>  .../selftests/bpf/progs/test_core_reloc_mods.c | 18 ++++++++++--------
>  .../bpf/progs/test_core_reloc_nesting.c        |  6 ++++--
>  .../bpf/progs/test_core_reloc_primitives.c     | 12 +++++++-----
>  .../bpf/progs/test_core_reloc_ptr_as_arr.c     |  4 +++-
>  9 files changed, 54 insertions(+), 36 deletions(-)
> 

Starting to get many layers of macros here but makes sense here.

Acked-by: John Fastabend <john.fastabend@...il.com>