netdev - Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d93a6713cf1d_85b2b0fc76de5b424@john-XPS-13-9370.notmuch>
Date:   Tue, 01 Oct 2019 12:18:09 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h
 into libbpf

Toke Høiland-Jørgensen wrote:
> 
> > +struct bpf_map_def {
> > +	unsigned int type;
> > +	unsigned int key_size;
> > +	unsigned int value_size;
> > +	unsigned int max_entries;
> > +	unsigned int map_flags;
> > +	unsigned int inner_map_idx;
> > +	unsigned int numa_node;
> > +};
> 
> Didn't we agree on no new bpf_map_def ABI in libbpf, and that all
> additions should be BTF-based?
> 
> -Toke
> 

We use libbpf on pre BTF kernels so in this case I think it makes
sense to add these fields. Having inner_map_idx there should allow
us to remove some other things we have sitting around.

.John