netdev - Re: [PATCH net-next] r8152: Add identifier names for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 03 Oct 2019 11:51:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     pmalani@...omium.org
Cc:     hayeswang@...ltek.com, grundler@...omium.org,
        netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH net-next] r8152: Add identifier names for function
 pointers

From: Prashant Malani <pmalani@...omium.org>
Date: Wed,  2 Oct 2019 14:09:33 -0700

> Checkpatch throws warnings for function pointer declarations which lack
> identifier names.
> 
> An example of such a warning is:
> 
> WARNING: function definition argument 'struct r8152 *' should
> also have an identifier name
> 739: FILE: drivers/net/usb/r8152.c:739:
> +               void (*init)(struct r8152 *);
> 
> So, fix those warnings by adding the identifier names.
> 
> While we are at it, also fix a character limit violation which was
> causing another checkpatch warning.
> 
> Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> Reviewed-by: Grant Grundler <grundler@...omium.org>

Applied.