netdev - RE: [PATCH net-next] r8152: Add identifier names for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18E612E@RTITMBSVM03.realtek.com.tw>
Date:   Thu, 3 Oct 2019 02:03:51 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Prashant Malani <pmalani@...omium.org>
CC:     "grundler@...omium.org" <grundler@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH net-next] r8152: Add identifier names for function pointers

Prashant Malani [mailto:pmalani@...omium.org]
> Sent: Thursday, October 03, 2019 5:10 AM
> To: Hayes Wang
> Cc: grundler@...omium.org; netdev@...r.kernel.org; nic_swsd; Prashant
> Malani
> Subject: [PATCH net-next] r8152: Add identifier names for function pointers
> 
> Checkpatch throws warnings for function pointer declarations which lack
> identifier names.
> 
> An example of such a warning is:
> 
> WARNING: function definition argument 'struct r8152 *' should
> also have an identifier name
> 739: FILE: drivers/net/usb/r8152.c:739:
> +               void (*init)(struct r8152 *);
> 
> So, fix those warnings by adding the identifier names.
> 
> While we are at it, also fix a character limit violation which was
> causing another checkpatch warning.
> 
> Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> Reviewed-by: Grant Grundler <grundler@...omium.org>

Acked-by: Hayes Wang <hayeswang@...ltek.com>

Best Regards,
Hayes