netdev - Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191003.120434.606814989607407144.davem@davemloft.net>
Date:   Thu, 03 Oct 2019 12:04:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: sja1105: Add support for port
 mirroring

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu,  3 Oct 2019 02:34:43 +0300

> +	already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS);
> +	if (already_enabled && enabled && general_params->mirr_port != to) {
> +		dev_err(priv->ds->dev,
> +			"Delete mirroring rules towards port %d first", to);
> +		return -EBUSY;
> +	}

In this situation, the user is trying to add a mirror rule to port 'to'
when we already have rules pointing to "general_params->mirr_port".

So you should be printing out the value of "general_params->mirr_port"
in this message rather than 'to'.