netdev - Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+h21hoKgFqK6aYErL_dpY+g+-6FzH5vbcuuAZ60Pnev8cn55A@mail.gmail.com>
Date:   Thu, 3 Oct 2019 22:15:29 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring

Hi David,

On Thu, 3 Oct 2019 at 22:04, David Miller <davem@...emloft.net> wrote:
>
> From: Vladimir Oltean <olteanv@...il.com>
> Date: Thu,  3 Oct 2019 02:34:43 +0300
>
> > +     already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS);
> > +     if (already_enabled && enabled && general_params->mirr_port != to) {
> > +             dev_err(priv->ds->dev,
> > +                     "Delete mirroring rules towards port %d first", to);
> > +             return -EBUSY;
> > +     }
>
> In this situation, the user is trying to add a mirror rule to port 'to'
> when we already have rules pointing to "general_params->mirr_port".
>
> So you should be printing out the value of "general_params->mirr_port"
> in this message rather than 'to'.

Good catch, thanks.

-Vladimir