netdev - Re: [PATCH net-next v2] net/rds: Use DMA memory pool allocation for rds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191003.121119.1777964964781562057.davem@davemloft.net>
Date:   Thu, 03 Oct 2019 12:11:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ka-cheong.poon@...cle.com
Cc:     netdev@...r.kernel.org, santosh.shilimkar@...cle.com,
        rds-devel@....oracle.com
Subject: Re: [PATCH net-next v2] net/rds: Use DMA memory pool allocation
 for rds_header

From: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
Date: Wed,  2 Oct 2019 21:11:08 -0700

> Currently, RDS calls ib_dma_alloc_coherent() to allocate a large piece
> of contiguous DMA coherent memory to store struct rds_header for
> sending/receiving packets.  The memory allocated is then partitioned
> into struct rds_header.  This is not necessary and can be costly at
> times when memory is fragmented.  Instead, RDS should use the DMA
> memory pool interface to handle this.  The DMA addresses of the pre-
> allocated headers are stored in an array.  At send/receive ring
> initialization and refill time, this arrary is de-referenced to get
> the DMA addresses.  This array is not accessed at send/receive packet
> processing.
> 
> Suggested-by: Håkon Bugge <haakon.bugge@...cle.com>
> Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>

Applied.