netdev - Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNhx+gQmRMb18UDRrmzciDYUbdezUh9bRhWG8_HTUCLk9w@mail.gmail.com>
Date:   Thu, 3 Oct 2019 12:50:23 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel <bjorn.topel@...il.com> wrote:
> >
> > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org> wrote:
> > >
> > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote:
> > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada
> > > ><yamada.masahiro@...ionext.com> wrote:
> > > >>
> > > >[...]
> > > >> > Yes, the BPF samples require clang/LLVM with BPF support to build. Any
> > > >> > suggestion on a good way to address this (missing tools), better than
> > > >> > the warning above? After the commit 394053f4a4b3 ("kbuild: make single
> > > >> > targets work more correctly"), it's no longer possible to build
> > > >> > samples/bpf without support in the samples/Makefile.
> > > >>
> > > >>
> > > >> You can with
> > > >>
> > > >> "make M=samples/bpf"
> > > >>
> > > >
> > > >Oh, I didn't know that. Does M= support "output" builds (O=)?
>
> No.
> O= points to the output directory of vmlinux,
> not of the external module.
>
> You cannot put the build artifacts from samples/bpf/
> in a separate directory.
>

Hmm, I can't even get "make M=samples/bpf/" to build. Am I missing
something obvious?

Prior 394053f4a4b3 "make samples/bpf/" and "make O=/foo/bar
samples/bpf/" worked, but I guess I can live with that...


Thanks!
Björn


>
>
> > > >I usually just build samples/bpf/ with:
> > > >
> > > >  $ make V=1 O=/home/foo/build/bleh samples/bpf/
> > > >
> > > >
> > > >Björn
> > >
> > > Shouldn't README be updated?
> > >
> >
> > Hmm, the M= variant doesn't work at all for me. The build is still
> > broken for me. Maybe I'm missing anything obvious...
> >
> >
> > > --
> > > Regards,
> > > Ivan Khoronzhuk
>
>
>
> --
> Best Regards
> Masahiro Yamada