netdev - Re: Marvell 88E6141 DSA degrades after 7fb5a711545d7d25fe9726a9ad277474dd83bd06

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003121314.GB15916@lunn.ch>
Date:   Thu, 3 Oct 2019 14:13:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Denis Odintsov <d.odintsov@...viangames.com>
Cc:     "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "h.feurstein@...il.com" <h.feurstein@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Marvell 88E6141 DSA degrades after
 7fb5a711545d7d25fe9726a9ad277474dd83bd06

On Thu, Oct 03, 2019 at 08:52:34AM +0000, Denis Odintsov wrote:
> Hello,
> 
> Thank you for your reply, now that you've said that I actually put WARN_ON(1) into mv88e6xxx_adjust_link and found out that it is not actually being called. Not even on 5.3. What I saw was a warning produced by block like "if (ds->ops->adjust_link)" in net/dsa/ code, but not the actual call. My bad. So it seems the content of the function is irrelevant, and as I can see there are many block like this, so most probably it is something one of these blocks were doing on 5.3 which changed to 5.4, which is way harder to debug I guess. Any other things I could check in that matter?
> 
> Denis. 

Hi Danis

Please don't top post. And wrap your emails to around 75 characters.

How did you decide on 7fb5a711545d7d25fe9726a9ad277474dd83bd06? Did
you do a git bisect?

    Andrew