netdev - Re: [patch net-next 00/10] net: genetlink: parse attrs for dumpit() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191006.154510.1792195598411183621.davem@davemloft.net>
Date:   Sun, 06 Oct 2019 15:45:10 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        alex.aring@...il.com, stefan@...enfreihafen.org,
        jon.maloy@...csson.com, ying.xue@...driver.com,
        johannes.berg@...el.com, mkubecek@...e.cz, yuehaibing@...wei.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 00/10] net: genetlink: parse attrs for
 dumpit() callback

From: Jiri Pirko <jiri@...nulli.us>
Date: Sat,  5 Oct 2019 20:04:32 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> In generic netlink, parsing attributes for doit() callback is already
> implemented. They are available in info->attrs.
> 
> For dumpit() however, each user which is interested in attributes have to
> parse it manually. Even though the attributes may be (depending on flag)
> already validated (by parse function).
> 
> Make usage of attributes in dumpit() more convenient and prepare
> info->attrs too.
> 
> Patchset also make the existing users of genl_family_attrbuf() converted
> to use info->attrs and removes the helper.

I really like this transformation, series applied, thanks Jiri.