netdev - Re: [PATCH net] net: dsa: b53: Do not clear existing mirrored port mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 06 Oct 2019 15:56:42 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, h.feurstein@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: Do not clear existing mirrored port
 mask

From: Florian Fainelli <f.fainelli@...il.com>
Date: Sat,  5 Oct 2019 15:05:18 -0700

> Clearing the existing bitmask of mirrored ports essentially prevents us
> from capturing more than one port at any given time. This is clearly
> wrong, do not clear the bitmask prior to setting up the new port.
> 
> Reported-by: Hubert Feurstein <h.feurstein@...il.com>
> Fixes: ed3af5fd08eb ("net: dsa: b53: Add support for port mirroring")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks.