netdev - Re: [PATCH v4 bpf-next 6/7] libbpf: add BPF_CORE_READ/BPF_CORE_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5411bdae-a723-6dd3-d35a-8ec825924b4e@fb.com>
Date:   Tue, 8 Oct 2019 15:10:08 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v4 bpf-next 6/7] libbpf: add
 BPF_CORE_READ/BPF_CORE_READ_INTO helpers

On 10/7/19 11:15 PM, Andrii Nakryiko wrote:
>>> +#define BPF_CORE_READ(src, a, ...)                                       \
>>> +     ({                                                                  \
>>> +             ___type(src, a, ##__VA_ARGS__) __r;                         \
>>> +             BPF_CORE_READ_INTO(&__r, src, a, ##__VA_ARGS__);            \
>>> +             __r;                                                        \
>>> +     })
>>> +
>> Since we're splitting things into
>> bpf_{helpers,helper_defs,endian,tracing}.h
>> how about adding all core macros into bpf_core_read.h ?
> ok, but maybe just bpf_core.h then?

bpf_core.h is too generic. It either needs to be capitalized,
which is unheard of for header files or some suffix added.
I think bpf_core_read.h is short enough and doesn't look like
bpf_core_write.h will be coming any time soon.
If you're worried about _read part then may be
bpf_core_access.h ?