netdev - Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08492ba6-eaf6-8c72-74fe-f49e0a95639e@huawei.com>
Date:   Tue, 8 Oct 2019 17:33:51 +0800
From:   "zhengbin (A)" <zhengbin13@...wei.com>
To:     <yhchuang@...ltek.com>, <pkshih@...ltek.com>,
        <kvalo@...eaurora.org>, <davem@...emloft.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val'

Sorry for the noise, please ignore this

On 2019/10/4 17:18, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function rtw8822c_dpk_dc_corr_check:
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable corr_val set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 5227c2ee453d ("rtw88:
> 8822c: add SW DPK support")
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: zhengbin <zhengbin13@...wei.com>
> ---
>  drivers/net/wireless/realtek/rtw88/rtw8822c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> index a300efd..52682d5 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2163,7 +2163,7 @@ static void rtw8822c_dpk_rxbb_dc_cal(struct rtw_dev *rtwdev, u8 path)
>  static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
>  {
>  	u16 dc_i, dc_q;
> -	u8 corr_val, corr_idx;
> +	u8 corr_idx;
>
>  	rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000900f0);
>  	dc_i = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(27, 16));
> @@ -2176,7 +2176,6 @@ static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
>
>  	rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0);
>  	corr_idx = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(7, 0));
> -	corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8));
>
>  	if (dc_i > 200 || dc_q > 200 || corr_idx < 40 || corr_idx > 65)
>  		return 1;
> --
> 2.7.4
>
>
> .
>