netdev - Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d0f771s7.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 08 Oct 2019 17:24:56 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "zhengbin \(A\)" <zhengbin13@...wei.com>
Cc:     <yhchuang@...ltek.com>, <pkshih@...ltek.com>,
        <davem@...emloft.net>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val'

(PLEASE don't top post, fixing that manually)

"zhengbin (A)" <zhengbin13@...wei.com> writes:

>
> On 2019/10/4 17:18, zhengbin wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function rtw8822c_dpk_dc_corr_check:
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable corr_val set but not used [-Wunused-but-set-variable]
>>
>> It is not used since commit 5227c2ee453d ("rtw88:
>> 8822c: add SW DPK support")
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: zhengbin <zhengbin13@...wei.com>
>
> Sorry for the noise, please ignore this

Why? What was wrong in the patch?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches