netdev - Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4441d56d-b7d0-00dc-2d54-93ca02db6f67@huawei.com>
Date:   Wed, 9 Oct 2019 08:17:24 +0800
From:   "zhengbin (A)" <zhengbin13@...wei.com>
To:     Kalle Valo <kvalo@...eaurora.org>
CC:     <yhchuang@...ltek.com>, <pkshih@...ltek.com>,
        <davem@...emloft.net>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] rtw88: 8822c: Remove set but not used variable 'corr_val'

On 2019/10/8 22:24, Kalle Valo wrote:

> (PLEASE don't top post, fixing that manually)
>
> "zhengbin (A)" <zhengbin13@...wei.com> writes:
>
>> On 2019/10/4 17:18, zhengbin wrote:
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function rtw8822c_dpk_dc_corr_check:
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable corr_val set but not used [-Wunused-but-set-variable]
>>>
>>> It is not used since commit 5227c2ee453d ("rtw88:
>>> 8822c: add SW DPK support")
>>>
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Signed-off-by: zhengbin <zhengbin13@...wei.com>
>> Sorry for the noise, please ignore this
> Why? What was wrong in the patch?

I am not sure whether we can just remove

corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8))?

rtw_read32_mask

  rtw_read32

    ops->read32

 

Thank you for your remind of do not top post.

BTW:  patchset 'net/rtlwifi: remove some unused variables' & patch 'rtlwifi: rtl8192ee: Remove set but not used variable 'err''

are acked-by Ping-Ke Shih, can you help deal with it?

>