netdev - Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 10:06:12 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Christoph Hellwig <hch@...radead.org>,
        Madalin-cristian Bucur <madalin.bucur@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Roy Pledge <roy.pledge@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to_virt()

On 09.10.2019 10:39, Christoph Hellwig wrote:
> On Tue, Oct 08, 2019 at 03:10:40PM +0300, Madalin Bucur wrote:
>> Centralize the phys_to_virt() calls.
> 
> You don't need to centralize those, you need to fix them.  Calling
> phys_to_virt on a dma_addr is completely bogus.
> 

Yeah, that's on my TODO list [1] for quite a while, among others. I'll 
return to it as soon as I'm done with the burning stuff I'm currently on.

[1] https://patchwork.kernel.org/patch/10968947/

---
Best Regards, Laurentiu