netdev - Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191009073926.GA6916@infradead.org>
Date:   Wed, 9 Oct 2019 00:39:26 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Madalin Bucur <madalin.bucur@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, roy.pledge@....com,
        laurentiu.tudor@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to_virt()

On Tue, Oct 08, 2019 at 03:10:40PM +0300, Madalin Bucur wrote:
> Centralize the phys_to_virt() calls.

You don't need to centralize those, you need to fix them.  Calling
phys_to_virt on a dma_addr is completely bogus.