lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Oct 2019 20:00:02 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Thomas Bogendoerfer <tbogendoerfer@...e.de> Cc: Jonathan Corbet <corbet@....net>, Ralf Baechle <ralf@...ux-mips.org>, Paul Burton <paul.burton@...s.com>, James Hogan <jhogan@...nel.org>, Lee Jones <lee.jones@...aro.org>, "David S. Miller" <davem@...emloft.net>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, netdev@...r.kernel.org, linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote: > dev = alloc_etherdev(sizeof(struct ioc3_private)); > - if (!dev) { > - err = -ENOMEM; > - goto out_disable; > - } > - > - if (pci_using_dac) > - dev->features |= NETIF_F_HIGHDMA; Looks like the NETIF_F_HIGHDMA feature will not longer be set, is that okay? > - err = pci_request_regions(pdev, "ioc3"); > - if (err) > - goto out_free; > + if (!dev) > + return -ENOMEM; > > SET_NETDEV_DEV(dev, &pdev->dev); > > ip = netdev_priv(dev); > - ip->dev = dev; > - ip->dma_dev = &pdev->dev; > - > - dev->irq = pdev->irq; > + ip->dma_dev = pdev->dev.parent; > + ip->regs = devm_platform_ioremap_resource(pdev, 0); > + if (!ip->regs) { > + err = -ENOMEM; > + goto out_free; > + }
Powered by blists - more mailing lists