netdev - Re: [PATCH net v2 0/2] net/sched: fix wrong behavior of MPLS push/pop action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191012124123.iy7cysxvroat3alt@netronome.com>
Date:   Sat, 12 Oct 2019 14:41:24 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     lkp@...el.com, davem@...emloft.net, john.hurley@...ronome.com,
        kbuild-all@...org, lorenzo@...nel.org, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net v2 0/2] net/sched: fix wrong behavior of MPLS
 push/pop action

On Sat, Oct 12, 2019 at 01:55:05PM +0200, Davide Caratti wrote:
> this series contains two fixes for TC 'act_mpls', that try to address
> two problems that can be observed configuring simple 'push' / 'pop'
> operations:
> - patch 1/2 avoids dropping non-MPLS packets that pass through the MPLS
>   'pop' action.
> - patch 2/2 fixes corruption of the L2 header that occurs when 'push'
>   or 'pop' actions are configured in TC egress path.
> 
> v2: - change commit message in patch 1/2 to better describe that the
>       patch impacts only TC, thanks to Simon Horman
>     - fix missing documentation of 'mac_len' in patch 2/2

Thanks for the follow-up, this looks good to me.

> Davide Caratti (2):
>   net: avoid errors when trying to pop MLPS header on non-MPLS packets
>   net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions
> 
>  include/linux/skbuff.h    |  5 +++--
>  net/core/skbuff.c         | 21 ++++++++++++---------
>  net/openvswitch/actions.c |  5 +++--
>  net/sched/act_mpls.c      | 12 ++++++++----
>  4 files changed, 26 insertions(+), 17 deletions(-)
> 
> -- 
> 2.21.0
>