netdev - Re: [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191015.105852.994786197393612301.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 10:58:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        jakub.kicinski@...ronome.com, geert@...ux-m68k.org,
        uwe@...ine-koenig.org, talgi@...lanox.com, saeedm@...lanox.com,
        dledford@...hat.com, jgg@...lanox.com, leonro@...lanox.com,
        ogerlitz@...lanox.com, sagi@...mberg.me
Subject: Re: [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as
 needed

From: Randy Dunlap <rdunlap@...radead.org>
Date: Fri, 11 Oct 2019 21:03:33 -0700

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> NET_VENDOR_BROADCOM is intended to control a kconfig menu only.
> It should not have anything to do with code generation.
> As such, it should not select DIMLIB for all drivers under
> NET_VENDOR_BROADCOM.  Instead each driver that needs DIMLIB should
> select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET).
> 
> Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/
> 
> Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied and queued up for -stable, thanks.