netdev - Re: [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191015072158.GA6957@unreal>
Date:   Tue, 15 Oct 2019 07:22:00 +0000
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Tal Gilboa <talgi@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Sagi Grimberg <sagi@...mberg.me>
Subject: Re: [PATCH] net: ethernet: broadcom: have drivers select DIMLIB as
 needed

On Fri, Oct 11, 2019 at 09:03:33PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> NET_VENDOR_BROADCOM is intended to control a kconfig menu only.
> It should not have anything to do with code generation.
> As such, it should not select DIMLIB for all drivers under
> NET_VENDOR_BROADCOM.  Instead each driver that needs DIMLIB should
> select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET).
>
> Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/
>
> Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Uwe Kleine-König <uwe@...ine-koenig.org>
> Cc: Tal Gilboa <talgi@...lanox.com>
> Cc: Saeed Mahameed <saeedm@...lanox.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-rdma@...r.kernel.org
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: Jason Gunthorpe <jgg@...lanox.com>
> Cc: Leon Romanovsky <leonro@...lanox.com>
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> Cc: Sagi Grimberg <sagi@...mberg.me>
> ---
>  drivers/net/ethernet/broadcom/Kconfig |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>