netdev - Re: [PATCH net] tcp: fix a possible lockdep splat in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191015.201529.1895543949965274139.davem@davemloft.net>
Date:   Tue, 15 Oct 2019 20:15:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        jakub.kicinski@...ronome.com, syzkaller@...glegroups.com
Subject: Re: [PATCH net] tcp: fix a possible lockdep splat in tcp_done()

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 14 Oct 2019 06:47:57 -0700

> syzbot found that if __inet_inherit_port() returns an error,
> we call tcp_done() after inet_csk_prepare_forced_close(),
> meaning the socket lock is no longer held.
> 
> We might fix this in a different way in net-next, but
> for 5.4 it seems safer to relax the lockdep check.
> 
> Fixes: d983ea6f16b8 ("tcp: add rcu protection around tp->fastopen_rsk")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.