netdev - Re: [PATCH 03/10 net-next] net/mlx5e: RX, Internal DMA mapping in page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3249A4F1-AF1D-4B7B-A23A-7F0086A8FCE9@gmail.com>
Date:   Fri, 18 Oct 2019 13:04:24 -0700
From:   "Jonathan Lemon" <jonathan.lemon@...il.com>
To:     "Jakub Kicinski" <jakub.kicinski@...ronome.com>
Cc:     brouer@...hat.com, ilias.apalodimas@...aro.org,
        saeedm@...lanox.com, tariqt@...lanox.com, netdev@...r.kernel.org,
        kernel-team@...com
Subject: Re: [PATCH 03/10 net-next] net/mlx5e: RX, Internal DMA mapping in
 page_pool

On 16 Oct 2019, at 18:33, Jakub Kicinski wrote:

> On Wed, 16 Oct 2019 15:50:21 -0700, Jonathan Lemon wrote:
>> From: Tariq Toukan <tariqt@...lanox.com>
>>
>> After RX page-cache is removed in previous patch, let the
>> page_pool be responsible for the DMA mapping.
>>
>> Issue: 1487631
>> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
>>
>> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
>
> IIUC you'll need to add DMA syncs here, no? map/unmap has syncing as
> side effect.

The driver still needs to do DMA sync for data transfers,
this only covers the initial mapping.
-- 
Jonathan