netdev - Re: [patch net-next] devlink: add format requirement for devlink param names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191018200822.GI2185@nanopsycho>
Date:   Fri, 18 Oct 2019 22:08:22 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, mlxsw@...lanox.com
Subject: Re: [patch net-next] devlink: add format requirement for devlink
 param names

Fri, Oct 18, 2019 at 07:43:04PM CEST, andrew@...n.ch wrote:
>On Fri, Oct 18, 2019 at 06:07:26PM +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Currently, the name format is not required by the code, however it is
>> required during patch review. All params added until now are in-lined
>> with the following format:
>> 1) lowercase characters, digits and underscored are allowed
>> 2) underscore is neither at the beginning nor at the end and
>>    there is no more than one in a row.
>> 
>> Add checker to the code to require this format from drivers and warn if
>> they don't follow.
>
>Hi Jiri
>
>Could you add a reference to where these requirements are derived
>from. What can go wrong if they are ignored? I assume it is something

Well, no reference. All existing params, both generic and driver
specific are following this format. I just wanted to make that required
so all params are looking similar.


>to do with sysfs?

No, why would you think so?


>
>      Andrew