[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191019192750.GB25148@lunn.ch>
Date: Sat, 19 Oct 2019 21:27:50 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jiri Pirko <jiri@...nulli.us>
Cc: David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>,
Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param
for ATU hash algorithm.
> >+address_translation_unit_hash [DEVICE, DRIVER-SPECIFIC]
>
> This is quite verbose. Can't you name this just "atu_hash" and be
> aligned with the function names and MV88E6XXX_DEVLINK_PARAM_ID_ATU_HASH
> and others?
Hi Jiri
I would use ATU_hash, but not atu_hash, sorry.
Hopefully somebody will implement bash command completion, making it
easier.
Andrew
Powered by blists - more mailing lists