netdev - Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191019210202.GN2185@nanopsycho>
Date:   Sat, 19 Oct 2019 23:02:02 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param
 for ATU hash algorithm.

Sat, Oct 19, 2019 at 09:27:50PM CEST, andrew@...n.ch wrote:
>> >+address_translation_unit_hash	[DEVICE, DRIVER-SPECIFIC]
>> 
>> This is quite verbose. Can't you name this just "atu_hash" and be
>> aligned with the function names and MV88E6XXX_DEVLINK_PARAM_ID_ATU_HASH
>> and others?
>
>Hi Jiri
>
>I would use ATU_hash, but not atu_hash, sorry.

That, I don't understand at all :/

The devlink param namespace is full of abbreviations. For example:
iwarp_cmt
gre_ver_check
enable_sriov
ignore_ari
msix_vec_per_pf_max
msix_vec_per_pf_min
fw_load_policy
reset_dev_on_drv_probe
acl_region_rehash_interval
enable_64b_cqe_eqe
enable_4k_uar

Why your thing is special?
Could you please follow the rest of the existing params?


>
>Hopefully somebody will implement bash command completion, making it
>easier.
>
>  Andrew