netdev - Re: [RFC 1/2] vhost: IFC VF hardware operation layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 18:21:50 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Zhu, Lingshan" <lingshan.zhu@...el.com>, mst@...hat.com,
        alex.williamson@...hat.com
Cc:     linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
        netdev@...r.kernel.org, dan.daly@...el.com,
        cunming.liang@...el.com, tiwei.bie@...el.com, jason.zeng@...el.com,
        zhiyuan.lv@...el.com
Subject: Re: [RFC 1/2] vhost: IFC VF hardware operation layer


On 2019/10/21 下午5:57, Zhu, Lingshan wrote:
>
> On 10/16/2019 4:45 PM, Jason Wang wrote:
>>
>> On 2019/10/16 上午9:30, Zhu Lingshan wrote:
>>> + */
>>> +#define IFCVF_TRANSPORT_F_START 28
>>> +#define IFCVF_TRANSPORT_F_END   34
>>> +
>>> +#define IFC_SUPPORTED_FEATURES \
>>> +        ((1ULL << VIRTIO_NET_F_MAC)            | \
>>> +         (1ULL << VIRTIO_F_ANY_LAYOUT)            | \
>>> +         (1ULL << VIRTIO_F_VERSION_1) | \
>>> +         (1ULL << VHOST_F_LOG_ALL)            | \
>>
>>
>> Let's avoid using VHOST_F_LOG_ALL, using the get_mdev_features() 
>> instead.
> Thanks, I will remove VHOST_F_LOG_ALL
>>
>>
>>> +         (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE)        | \
>>> +         (1ULL << VIRTIO_NET_F_CTRL_VQ)            | \
>>> +         (1ULL << VIRTIO_NET_F_STATUS)            | \
>>> +         (1ULL << VIRTIO_NET_F_MRG_RXBUF)) /* not fully supported */
>>
>>
>> Why not having VIRTIO_F_IOMMU_PLATFORM and VIRTIO_F_ORDER_PLATFORM?
>
> I will add VIRTIO_F_ORDER_PLATFORM, for VIRTIO_F_IOMMU_PLATFORM, if we 
> add this bit, QEMU may enable viommu, can cause troubles in LM


Qemu has mature support of vIOMMU support for VFIO device, it can shadow 
IO page tables and setup them through DMA ioctl of vfio containers. Any 
issue you saw here?

Btw, to test them quickly, you can implement set_config/get_config and 
test them through virtio-mdev/kernel drivers as well.

Thanks


> (through we don't support LM in this version driver)
>
> Thanks,
> BR
> Zhu Lingshan
>>
>> Thanks
>>