netdev - Re: [PATCH 10/10] net: ethernet: ixp4xx: Use parent dev for DMA pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0BSN8jxxnjPgSoLFouM3awS9DryL0_4Qcwd_cwn+aUEg@mail.gmail.com>
Date:   Mon, 21 Oct 2019 12:27:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Networking <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 10/10] net: ethernet: ixp4xx: Use parent dev for DMA pool

On Mon, Oct 21, 2019 at 2:10 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> Use the netdevice struct device .parent field when calling
> dma_pool_create(): the .dma_coherent_mask and .dma_mask
> pertains to the bus device on the hardware (platform)
> bus in this case, not the struct device inside the network
> device. This makes the pool allocation work.
>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Has this always been broken, or can you identify when it stopped
working? It might be a candidate for stable backports.

> ---
>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> index 0996046bd046..3ee6d7232eb9 100644
> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -1090,7 +1090,7 @@ static int init_queues(struct port *port)
>         int i;
>
>         if (!ports_open) {
> -               dma_pool = dma_pool_create(DRV_NAME, &port->netdev->dev,
> +               dma_pool = dma_pool_create(DRV_NAME, port->netdev->dev.parent,
>                                            POOL_ALLOC_SIZE, 32, 0);
>                 if (!dma_pool)
>                         return -ENOMEM;
> --
> 2.21.0
>