netdev - Re: [PATCH 09/10] net: ethernet: ixp4xx: Get port ID from base address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1qbJC+nFZD0ZKDqWE6ORbEEZbO_Y+MZBS--ym_VQ6fXQ@mail.gmail.com>
Date:   Mon, 21 Oct 2019 12:30:16 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Networking <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 09/10] net: ethernet: ixp4xx: Get port ID from base address

On Mon, Oct 21, 2019 at 2:10 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> The port->id was picked from the platform device .id field,
> but this is not supposed to be used for passing around
> random numbers in hardware. Identify the port ID number
> from the base address instead.
>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

I'm not sure this is better, as now the driver hardcodes the physical
address, and the port->id value is still the same as the pdev->id
value that all boards still pass.

Is this just meant to avoid setting the port id explicitly in DT?

       Arnd