netdev - Re: [patch net-next v3 2/3] devlink: replace spaces in dpipe field names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43e9c782-a5a0-0ee4-8bb3-db610884ce96@gmail.com>
Date:   Mon, 21 Oct 2019 09:17:43 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jakub.kicinski@...ronome.com, andrew@...n.ch,
        mlxsw@...lanox.com
Subject: Re: [patch net-next v3 2/3] devlink: replace spaces in dpipe field
 names

On 10/21/19 8:26 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> To be aligned with upcoming formatting restrictions, replace spaces
> in dpipe filed names to underscores.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
> v2->v3:
> - new patch
> ---
>  net/core/devlink.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 97e9a2246929..45b6a9a964f6 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -33,7 +33,7 @@
>  
>  static struct devlink_dpipe_field devlink_dpipe_fields_ethernet[] = {
>  	{
> -		.name = "destination mac",
> +		.name = "destination_mac",
>  		.id = DEVLINK_DPIPE_FIELD_ETHERNET_DST_MAC,
>  		.bitwidth = 48,
>  	},
> @@ -50,7 +50,7 @@ EXPORT_SYMBOL(devlink_dpipe_header_ethernet);
>  
>  static struct devlink_dpipe_field devlink_dpipe_fields_ipv4[] = {
>  	{
> -		.name = "destination ip",
> +		.name = "destination_ip",
>  		.id = DEVLINK_DPIPE_FIELD_IPV4_DST_IP,
>  		.bitwidth = 32,
>  	},
> @@ -67,7 +67,7 @@ EXPORT_SYMBOL(devlink_dpipe_header_ipv4);
>  
>  static struct devlink_dpipe_field devlink_dpipe_fields_ipv6[] = {
>  	{
> -		.name = "destination ip",
> +		.name = "destination_ip",
>  		.id = DEVLINK_DPIPE_FIELD_IPV6_DST_IP,
>  		.bitwidth = 128,
>  	},
> 

These are all exposed to userspace, so changing this format breaks
existing users