[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <60dc428e-679e-fb16-38c2-82900c9013de@gmail.com>
Date: Mon, 21 Oct 2019 09:20:07 -0600
From: David Ahern <dsahern@...il.com>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: davem@...emloft.net, jakub.kicinski@...ronome.com, andrew@...n.ch,
mlxsw@...lanox.com
Subject: Re: [patch net-next v3 3/3] devlink: add format requirement for
devlink object names
On 10/21/19 8:26 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
>
> Currently, the name format is not required by the code, however it is
> required during patch review. All params added until now are in-lined
> with the following format:
> 1) lowercase characters, digits and underscored are allowed
> 2) underscore is neither at the beginning nor at the end and
> there is no more than one in a row.
>
> Add checker to the code to require this format from drivers and warn if
> they don't follow. This applies to params, resources, reporters,
> traps, trap groups, dpipe tables and dpipe fields.
>
This seems random and without any real cause. There is no reason to
exclude dash and uppercase for example in the names.
Powered by blists - more mailing lists