lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Oct 2019 16:00:26 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Vasundhara Volam <vasundhara-v.volam@...adcom.com> Cc: Sheetal Tigadoli <sheetal.tigadoli@...adcom.com>, Rafał Miłecki <zajec5@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Michal Simek <michal.simek@...inx.com>, Rajan Vaja <rajan.vaja@...inx.com>, Scott Branden <scott.branden@...adcom.com>, Ray Jui <ray.jui@...adcom.com>, Vikram Prakash <vikram.prakash@...adcom.com>, Jens Wiklander <jens.wiklander@...aro.org>, Michael Chan <michael.chan@...adcom.com>, "David S. Miller" <davem@...emloft.net>, Vikas Gupta <vikas.gupta@...adcom.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, tee-dev@...ts.linaro.org, bcm-kernel-feedback-list@...adcom.com, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH V2 3/3] bnxt_en: Add support to collect crash dump via ethtool On Mon, 21 Oct 2019 10:05:18 +0530, Vasundhara Volam wrote: > On Fri, Oct 18, 2019 at 10:31 PM Jakub Kicinski wrote: > > On Fri, 18 Oct 2019 12:04:35 +0530, Vasundhara Volam wrote: > > > On Fri, Oct 18, 2019 at 12:52 AM Jakub Kicinski wrote: > > > > On Thu, 17 Oct 2019 17:31:22 +0530, Sheetal Tigadoli wrote: > > > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > > > > > index 51c1404..1596221 100644 > > > > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > > > > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c > > > > > @@ -3311,6 +3311,23 @@ static int bnxt_get_coredump(struct bnxt *bp, void *buf, u32 *dump_len) > > > > > return rc; > > > > > } > > > > > > > > > > +static int bnxt_set_dump(struct net_device *dev, struct ethtool_dump *dump) > > > > > +{ > > > > > + struct bnxt *bp = netdev_priv(dev); > > > > > + > > > > > +#ifndef CONFIG_TEE_BNXT_FW > > > > > + return -EOPNOTSUPP; > > > > > +#endif > > > > > > > > if (!IS_ENABLED(...)) > > > > return x; > > > > > > > > reads better IMHO > > > Okay. > > > > > > > > > > > But also you seem to be breaking live dump for systems with > > > > CONFIG_TEE_BNXT_FW=n > > > Yes, we are supporting set_dump only if crash dump is supported. > > > > It's wrong. > > Sorry not very clear. You are saying that support set_dump all the > time and return error, if the config option is not enabled? If yes, I > will modify the same way as it makes sense. Yes, I think users can expect that set will work even if there is only one dump type/flag supported. Technically implementing the set is not required from functional perspective, however, we could imagine software that always does a set before a get, and the set should not fail.
Powered by blists - more mailing lists