netdev - Re: [PATCH net-next 2/4] bus: fsl-mc: add the fsl_mc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021231317.GA27462@lunn.ch>
Date:   Tue, 22 Oct 2019 01:13:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        laurentiu.tudor@....com, f.fainelli@...il.com, rmk@...linux.org.uk
Subject: Re: [PATCH net-next 2/4] bus: fsl-mc: add the fsl_mc_get_endpoint
 function

Hi Ioana

> +/**
> + * dprc_get_connection() - Get connected endpoint and link status if connection
> + *			exists.
> + * @mc_io:	Pointer to MC portal's I/O object
> + * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token:	Token of DPRC object
> + * @endpoint1:	Endpoint 1 configuration parameters
> + * @endpoint2:	Returned endpoint 2 configuration parameters
> + * @state:	Returned link state:
> + *		1 - link is up;
> + *		0 - link is down;
> + *		-1 - no connection (endpoint2 information is irrelevant)
> + *
> + * Return:     '0' on Success; -ENAVAIL if connection does not exist.

#define	ENAVAIL		119	/* No XENIX semaphores available */

This is not a semaphore.

How about

#define	ENOTCONN	107	/* Transport endpoint is not connected */

	Andrew