netdev - Re: [PATCH net-next] net: macb: convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022122459.GE3125@piout.net>
Date:   Tue, 22 Oct 2019 14:24:59 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        davem@...emloft.net, nicolas.ferre@...rochip.com,
        netdev@...r.kernel.org, thomas.petazzoni@...tlin.com
Subject: Re: [PATCH net-next] net: macb: convert to phylink

On 18/10/2019 21:08:23+0100, Russell King - ARM Linux admin wrote:
> On Fri, Oct 18, 2019 at 09:08:10PM +0200, Andrew Lunn wrote:
> > On Fri, Oct 18, 2019 at 04:39:24PM +0200, Antoine Tenart wrote:
> > > This patch converts the MACB Ethernet driver to the Phylink framework.
> > > The MAC configuration is moved to the Phylink ops and Phylink helpers
> > > are now used in the ethtools functions.
> 
> What seems to be missing is "why".  It isn't obvious from the patch why
> this conversion is being done...
> 

One of the first goal was to get access to
phylink_ethtool_get_pauseparam/phylink_ethtool_set_pauseparam and the
flow control logic instead of having to open code it.

There are also boards with a zynqmp and SFP cages.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com