netdev - Re: [PATCH] net: phy: dp83867: support Wake on LAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022123424.GA5707@lunn.ch>
Date:   Tue, 22 Oct 2019 14:34:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Thomas Hämmerle 
        <Thomas.Haemmerle@...fvision.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "m.tretter@...gutronix.de" <m.tretter@...gutronix.de>
Subject: Re: [PATCH] net: phy: dp83867: support Wake on LAN

On Tue, Oct 22, 2019 at 11:11:07AM +0000, Thomas Hämmerle wrote:
> +		if (wol->wolopts & WAKE_MAGICSECURE) {
> +			phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> +				      (wol->sopass[1] << 8) | wol->sopass[0]);
> +			phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> +				      (wol->sopass[3] << 8) | wol->sopass[2]);
> +			phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
> +				      (wol->sopass[5] << 8) | wol->sopass[3]);

Hi Thomas

I see sopass[3] twice here. Is that a typo?

  Andrew