netdev - Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1facd1c-00e4-e276-3898-b59e9d7281a2@gmail.com>
Date:   Wed, 23 Oct 2019 16:16:27 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, andrew@...n.ch, mlxsw@...lanox.com
Subject: Re: [patch net-next v3 3/3] devlink: add format requirement for
 devlink object names

On 10/21/19 11:59 PM, Jiri Pirko wrote:
> Mon, Oct 21, 2019 at 06:11:33PM CEST, dsahern@...il.com wrote:
>> On 10/21/19 9:56 AM, Jiri Pirko wrote:
>>>
>>> I forgot to update the desc. Uppercase chars are now allowed as Andrew
>>> requested. Regarding dash, it could be allowed of course. But why isn't
>>> "_" enough. I mean, I think it would be good to maintain allowed chars
>>> within a limit.
>>
>> That's a personal style question. Is "fib-rules" less readable than
>> "fib_rules"? Why put such limitations in place if there is no
>> justifiable reason?
> 
> You mean any limitation?
> 

I mean why are you pushing a patch to limit what characters can be used
in names, and why are you deciding '-' is not ok but '_' is?

It just seems so random and not driven by some real limitation (e.g.,
entries in a filesystem).