netdev - Re: [PATCH net-next 2/6] sfc: perform XDP processing on received packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdf2137e-808e-2607-0c65-e609741242c0@solarflare.com>
Date:   Thu, 24 Oct 2019 15:45:57 +0100
From:   Charles McLachlan <cmclachlan@...arflare.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net-next 2/6] sfc: perform XDP processing on received
 packets.

On 22/10/2019 23:45, Jesper Dangaard Brouer wrote:

>> +	case XDP_REDIRECT:
>> +		rc = xdp_do_redirect(efx->net_dev, &xdp, xdp_prog);
>> +		if (rc) {
> 
> Can we call the 'rc' variable 'err' instead?
> And give it an unlikely().

Yes. Done in next version of the patch set.