netdev - Re: [patch iproute2-next v5 0/3] ip: add support for alternative names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191028073800.GC2193@nanopsycho>
Date:   Mon, 28 Oct 2019 08:38:00 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, stephen@...workplumber.org,
        roopa@...ulusnetworks.com, dcbw@...hat.com,
        nikolay@...ulusnetworks.com, mkubecek@...e.cz, andrew@...n.ch,
        parav@...lanox.com, saeedm@...lanox.com, f.fainelli@...il.com,
        sd@...asysnail.net, sbrivio@...hat.com, pabeni@...hat.com,
        mlxsw@...lanox.com
Subject: Re: [patch iproute2-next v5 0/3] ip: add support for alternative
 names

Sun, Oct 27, 2019 at 06:16:25PM CET, dsahern@...il.com wrote:
>On 10/24/19 4:20 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> This patchset adds support for alternative names caching,
>> manipulation and usage.
>> 
>
>something is still not right with this change:
>
>$ ip li add veth1 type veth peer name veth2
>$ ip li prop add dev veth1 altname veth1_by_another_name
>
>$ ip li sh dev veth1
>15: veth1@...h2: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state
>DOWN mode DEFAULT group default qlen 1000
>    link/ether 1e:6e:bc:26:52:f6 brd ff:ff:ff:ff:ff:ff
>    altname veth1_by_another_name
>
>$ ip li sh dev veth1_by_another_name
>Device "veth1_by_another_name" does not exist.
>
>$ ip li set dev veth1_by_another_name up
>Error: argument "veth1_by_another_name" is wrong: "dev" not a valid ifname

Odd. This works for me fine:
bash-5.0# ip li prop add dev veth1 altname veth1_by_another_name
bash-5.0# ip li sh dev veth1
4: veth1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 82:ce:19:28:bb:f5 brd ff:ff:ff:ff:ff:ff
    altname veth1_by_another_name
bash-5.0# ip li sh dev veth1_by_another_name
4: veth1: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 82:ce:19:28:bb:f5 brd ff:ff:ff:ff:ff:ff
    altname veth1_by_another_name
bash-5.0# ip li set dev veth1_by_another_name up


Did you by any chance forget to apply the last patch?