netdev - Re: [EXT] Re: [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49a629ba-c143-896a-d24d-32e04c430b77@huawei.com>
Date:   Mon, 28 Oct 2019 15:49:25 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Igor Russkikh <Igor.Russkikh@...antia.com>,
        Simon Horman <simon.horman@...ronome.com>
CC:     Egor Pomozov <epomozov@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        "Sergey Samoilenko" <Sergey.Samoilenko@...antia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next] net: aquantia: Fix build error wihtout
 CONFIG_PTP_1588_CLOCK

On 2019/10/26 19:09, Igor Russkikh wrote:
> 
>>> Hi YueHaibing,
>>>
>>> thanks for your patch.
>>>
>>> What is the motivation for not using the existing copy of this function?
>>
>> I'm not sure if PTP_1588_CLOCK is needed at this config,
>> using the existing function need to PTP_1588_CLOCK is selected.
> 
> Hi YueHaibing,
> 
> Please checkout this patch: https://patchwork.ozlabs.org/patch/1184620/
> 
> It fixes the problem without duplicating the function.

Yes, this fix the issue.

> 
> Regards,
>   Igor
> 
>