netdev - Re: Compile build issues with samples/bpf/ again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNhSsnFXFG1ZHYCxSmYjdv0bWWszToJzmH1KFn7G5CBavQ@mail.gmail.com>
Date:   Wed, 30 Oct 2019 11:53:21 +0100
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        BPF-dev-list <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eric Sage <eric@...e.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>
Subject: Re: Compile build issues with samples/bpf/ again

On Wed, 30 Oct 2019 at 11:43, Jesper Dangaard Brouer <brouer@...hat.com> wrote:
>
> Hi Maintainers,
>
> It is annoy to experience that simply building kernel tree samples/bpf/
> is broken as often as it is.  Right now, build is broken in both DaveM
> net.git and bpf.git.  ACME have some build fixes queued from Björn
> Töpel. But even with those fixes, build (for samples/bpf/task_fd_query_user.c)
> are still broken, as reported by Eric Sage (15 Oct), which I have a fix for.
>

Hmm, something else than commit e55190f26f92 ("samples/bpf: Fix build
for task_fd_query_user.c")?

> Could maintainers add building samples/bpf/ to their build test scripts?
> (make headers_install && make M=samples/bpf)
>
> Also I discovered, the command to build have also recently changed:
> - Before : make samples/bpf/   or  simply make in subdir samples/bpf/
> - new cmd: make M=samples/bpf  and in subdir is broken
>
> Anyone knows what commit introduced this change?
> (I need it for a fixes tag, when updating README.rst doc)
>
> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer
>